Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react-aspen crashing if an orphaned item is being rendered somehow? #15

Closed
wants to merge 1 commit into from
Closed

Conversation

LoganDark
Copy link

Fixes #14

It might be worth investigating how the heck an orphaned item even gets here, but I can't repro it using the demo even using the exact same sequence of inotify events that cause this situation in my application.

@LoganDark
Copy link
Author

@NeekSandhu I've manually made this change in my application, and while the error still shows up in console, it no longer breaks the tree view. All functionality seems to be preserved just fine

@zikaari
Copy link
Owner

zikaari commented Oct 7, 2021

@LoganDark Please continue to use the patched version of aspen in your own app until I investigate the root problem. I'd really appreciate it if you can spend some time on coming up with deterministic repro steps (even if that is to forcefully re-render the app 60 times a second like you speculated in the main issue)

@zikaari zikaari closed this Oct 7, 2021
@LoganDark
Copy link
Author

LoganDark commented Oct 7, 2021

@LoganDark Please continue to use the patched version of aspen in your own app until I investigate the root problem. I'd really appreciate it if you can spend some time on coming up with deterministic repro steps (even if that is to forcefully re-render the app 60 times a second like you speculated in the main issue)

I did forcefully re-render the app 60 times a second - in the example, that did nothing. I also recreated the exact sequence of inotify events that seemed to cause the problem in my own app. No dice. Combined the two, nothing yet.

So far, I've spent more time trying to find the issue than I did ignoring it.

@LoganDark LoganDark deleted the patch-1 branch October 7, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught Error: orphaned/detached FileEntries don't have path (except Root)
2 participants