-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing model info quirk for TUYA TZE200 #1740
Conversation
This commit adds a missing model info quirk for TUYA TZE200 without which it'll only show VOClevel sensor instead of all the available sensors on the device.
Pull Request Test Coverage Report for Build 3021063200
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## dev #1740 +/- ##
=======================================
Coverage 71.56% 71.56%
=======================================
Files 239 239
Lines 7358 7358
=======================================
Hits 5266 5266
Misses 2092 2092
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could you include a link to the device manufacturer? |
@javicalle it's a follow-up to #1367 Had to add this line otherwise most of the sensors were not found. |
No, there is no need. I suppose that is some kind of upgraded version with the GPP cluster. It's this the device?: |
Yep, that's this one, however it seems that I might need to do some filtering over the CO2 meter, as it's giving out garbage data. Alright, looked into the issue a bit more, see #1406 Edit #2: the sensors were mismatched, and it seems that after properly moving sensor to their actual device the garbage does not appear anymore. I'll watch the logs for a while and if garbage reappears I'll add some simple garbage filter (is that even doable in quirks? would love some point of reference), but other than that it seems that this device requires a different |
Sometimes the device needs to be repaired to fix the garbage data (random 0 values).
It would be a pity because that would mean to duplicate also the
I believe that is not supported in the present implementation: |
You can see a bit of history in zigbee2mqtt implementation: Koenkk/zigbee2mqtt#11033 They filter garbage values and there is correct value mapping too |
Alright, it means that I need to figure out some basic denouncing and filtering for the data there. Hoped that there's something for that in ZHA codebase already, but I can write some simple helpers myself. The zigbee2mqtt issue is of this device, so I can try to mirror the mappings too, might be that we won't need another mapping class. |
This still needs additional modifications though since device doesn't report values correctly. This device uses DP22 (instead of DP2) for CO2, DP2 for PM2.5 and DP20 (instead of DP22) for HCHO/Formaldehyde. Also DP2 produces garbage values of 0xAAAC and 0xAAAB that drastically differ from real values that close to 0. |
Any update on this fix? |
This commit adds a missing model info quirk for TUYA TZE200 without which it'll only show VOClevel sensor instead of all the available sensors on the device.