Drop empty frames (#600)

zigpy · Dec 11, 2023 · 15b3223 · 15b3223
1 parent 1ac01ed
commit 15b3223
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/bellows/ezsp/__init__.py b/bellows/ezsp/__init__.py
@@ -302,6 +302,10 @@ def frame_received(self, data: bytes) -> None:
             LOGGER.debug("Ignoring frame, protocol is not configured: %r", data)
             return
 
+        if not data:
+            LOGGER.debug("Ignoring empty frame")
+            return
+
         self._protocol(data)
 
     async def get_board_info(

diff --git a/tests/test_ezsp.py b/tests/test_ezsp.py
@@ -863,3 +863,12 @@ async def test_reset_custom_eui64(ezsp_f):
     assert ezsp_f.setTokenData.mock_calls == [
         call(t.NV3KeyId.CREATOR_STACK_RESTORED_EUI64, 0, t.LVBytes32(b"\xFF" * 8))
     ]
+
+
+def test_empty_frame_received(ezsp_f):
+    """Test dropping of invalid, empty frames."""
+    ezsp_f._protocol = MagicMock(spec_set=ezsp_f._protocol)
+    ezsp_f._protocol.__call__ = MagicMock()
+    ezsp_f.frame_received(b"")
+
+    assert ezsp_f._protocol.__call__.mock_calls == []