Fix/ 404 on events fetch #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DevAseel
commented
Aug 5, 2023
DevAseel
commented
- This PR takes care of Fix 404 when fetching events #23
zidhuss
reviewed
Aug 5, 2023
|
🚀 Deployed on https://deploy-preview-30--muscat-tech.netlify.app |
|
@zidhuss I noticed that the link PR was merged, so I rebased. Apologies. |
|
No need to apologise it's all good 👍 The approach is nice but unfortunately only looks to be working on Google Chrome. Firefox: Safari: |
@zidhuss made a quick fix, but a dirty one haha. I think this might be the only way (other than creating an endpoint). I will leave it to your judgment. |
zidhuss
requested changes
Aug 5, 2023
|
@zidhuss Really great suggestions! Covered them on my last commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.