-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update protocol contracts to v8 #159
Conversation
WalkthroughThe recent updates include upgrading the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@coderabbitai review |
Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
Files selected for processing (2)
- package.json (1 hunks)
- packages/client/src/getFees.ts (2 hunks)
Files skipped from review due to trivial changes (1)
- package.json
Additional comments not posted (2)
packages/client/src/getFees.ts (2)
15-20
: Approved: Good addition of error handling.The addition of error handling for fetching
withdrawGasFee
improves the robustness of the function. The early return ensures that subsequent logic is not executed if an error occurs.
98-98
: Approved: Good addition of conditional check.The addition of the conditional check before pushing the fee to the
omnichain
array ensures that only truthy values are added, improving the reliability of the function.
Summary by CodeRabbit
Bug Fixes
withdrawGasFee
to ensure the application returns early in case of an error and adds the fee only if it is valid.Chores
@zetachain/protocol-contracts
from7.0.0
to8.0.0-rc1
.