Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update protocol contracts to v8 #159

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Jul 3, 2024

Summary by CodeRabbit

  • Bug Fixes

    • Improved error handling for fetching withdrawGasFee to ensure the application returns early in case of an error and adds the fee only if it is valid.
  • Chores

    • Updated the version of @zetachain/protocol-contracts from 7.0.0 to 8.0.0-rc1.

Copy link
Contributor

coderabbitai bot commented Jul 3, 2024

Walkthrough

The recent updates include upgrading the @zetachain/protocol-contracts dependency from version 7.0.0 to 8.0.0-rc1 in package.json. In addition, error handling has been introduced in the fetchZEVMFees function within getFees.ts to address potential issues when fetching withdrawGasFee. The function now returns early if an error occurs and includes a conditional check to ensure only truthy fees are processed.

Changes

File Change Summary
package.json Updated @zetachain/protocol-contracts version from 7.0.0 to 8.0.0-rc1.
.../client/src/getFees.ts Introduced error handling when fetching withdrawGasFee and a conditional check for truthy fees.

Poem

In the heart of code, where updates bloom,
A version rose, dispelling gloom.
Errors now caught with careful hand,
Truthy fees, the rule of the land.
Code's a garden, growing bright,
With each change, we reach new heights. 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fadeev
Copy link
Member Author

fadeev commented Jul 3, 2024

@coderabbitai review

Copy link
Contributor

coderabbitai bot commented Jul 3, 2024

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3ada76c and 5c31555.

Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing (2)
  • package.json (1 hunks)
  • packages/client/src/getFees.ts (2 hunks)
Files skipped from review due to trivial changes (1)
  • package.json
Additional comments not posted (2)
packages/client/src/getFees.ts (2)

15-20: Approved: Good addition of error handling.

The addition of error handling for fetching withdrawGasFee improves the robustness of the function. The early return ensures that subsequent logic is not executed if an error occurs.


98-98: Approved: Good addition of conditional check.

The addition of the conditional check before pushing the fee to the omnichain array ensures that only truthy values are added, improving the reliability of the function.

@fadeev fadeev marked this pull request as ready for review July 4, 2024 06:38
@fadeev fadeev requested review from andresaiello, lucas-janon and a team as code owners July 4, 2024 06:38
@fadeev fadeev merged commit 89565d3 into main Jul 10, 2024
5 checks passed
@fadeev fadeev deleted the protocol-contracts-v8 branch July 10, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants