-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add revert handling #12
Conversation
@skosito I think This way we mirror the behavior of the real environment allowing a developer to test both native gas and ERC-20 tokens. |
For simplicity, we can just start with ETH & ZRC-20 ETH support. And possibly add ERC-20 later. |
packages/localnet/src/index.ts
Outdated
const testZRC20 = await zrc20Factory | ||
.connect(fungibleModuleSigner) | ||
.deploy( | ||
"TOKEN", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"TOKEN", | |
"ZRC-20 ETH", |
@skosito thanks for this PR! Now a example contract works when called from EVM! 🙌 |
sure i will try to update |
adding just zrc-eth for now so we handle current flow we have, i think simpler approach is that we can extend with more zrc20s and other functionalities as we add examples, since atm we are not supporting all events anyways, and keeping localnet simple as possible would be nice - we can add issues as we go i also added same revert handling on zevm side |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverts are working now!
covering flow:
is this useful? also it seems localnet in general needs some modifications, for example currently it was broken because zrc20 contract was missing - in this case, onCrossChainCall expects zrc20 to be passed as arg, which zrc20 we would send if localnet doesn't deploy some?