Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error on Homepage Demo CTA #2474

Merged
merged 1 commit into from
Jul 13, 2024
Merged

fix: Error on Homepage Demo CTA #2474

merged 1 commit into from
Jul 13, 2024

Conversation

japhethLG
Copy link
Contributor

Description

Fix wrong props of homepage cta; Removed spans in headings for articles

Fixes #2472, #2473

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Manual Test

Screenshots / Screen recording

Before:
image
image

After:
image
image

@japhethLG japhethLG requested a review from darwin808 July 12, 2024 16:18
@darwin808 darwin808 merged commit aa3c1e5 into stage Jul 13, 2024
9 checks passed
@darwin808 darwin808 deleted the fix/homepage-demo-cta branch July 13, 2024 03:47
japhethLG added a commit that referenced this pull request Nov 22, 2024
# Description

Fix wrong props of homepage cta; Removed spans in headings for articles

Fixes #2472, #2473

## Type of change

Please delete options that are not relevant.

- [x] Bug fix (non-breaking change which fixes an issue)

# How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce.

- [x] Manual Test

# Screenshots / Screen recording
Before:

![image](https://github.com/user-attachments/assets/ef1994f5-81ee-42cd-b185-a4d166c27417)

![image](https://github.com/user-attachments/assets/f49dd7ff-8872-4adf-a1c7-b866c280a9e2)

After:

![image](https://github.com/user-attachments/assets/416038be-33cd-4e60-8a58-1ec2a37fa71d)

![image](https://github.com/user-attachments/assets/0c761b0e-a65c-46cc-aeec-66182d8f5ae3)
japhethLG added a commit that referenced this pull request Nov 22, 2024
# Description

Fix wrong props of homepage cta; Removed spans in headings for articles

Fixes #2472, #2473

## Type of change

Please delete options that are not relevant.

- [x] Bug fix (non-breaking change which fixes an issue)

# How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce.

- [x] Manual Test

# Screenshots / Screen recording
Before:

![image](https://github.com/user-attachments/assets/ef1994f5-81ee-42cd-b185-a4d166c27417)

![image](https://github.com/user-attachments/assets/f49dd7ff-8872-4adf-a1c7-b866c280a9e2)

After:

![image](https://github.com/user-attachments/assets/416038be-33cd-4e60-8a58-1ec2a37fa71d)

![image](https://github.com/user-attachments/assets/0c761b0e-a65c-46cc-aeec-66182d8f5ae3)
giseleblair pushed a commit that referenced this pull request Nov 22, 2024
#2459 
#2468
#2470 
#2474 
#2477
#2488 
#2490
#2491

---------

Signed-off-by: Japheth Louie M. Gofredo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#website Error on Homepage Demo CTA
2 participants