Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): rerender input #2116

Merged
merged 3 commits into from
Nov 16, 2023
Merged

fix(dashboard): rerender input #2116

merged 3 commits into from
Nov 16, 2023

Conversation

darwin808
Copy link
Contributor

@darwin808 darwin808 commented Nov 12, 2023

Description

  • optimize rerendering of dashboard page when searching for instances

Closes #2124

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots / Screen recording

Please add screenshots or recording if applicable

Before

Screen.Recording.2023-11-13.at.1.31.43.PM.mov

After

Screen.Recording.2023-11-13.at.1.35.21.PM.mov

Copy link

Pull reviewers stats

Stats of the last 30 days for website:

User Total reviews Time to review Total comments
ardeay 8 13h 59m 7
darwin808 4 19h 2m 0
giseleblair 2 2h 5m 0
b-estevez 1 6m 0
gtllien 1 2h 53m 0

@darwin808 darwin808 marked this pull request as draft November 12, 2023 13:36
@darwin808 darwin808 self-assigned this Nov 13, 2023
@darwin808 darwin808 force-pushed the fix/dashboard-input-1 branch from 72a362b to 9e91207 Compare November 13, 2023 05:47
@darwin808 darwin808 marked this pull request as ready for review November 15, 2023 08:51
@darwin808 darwin808 merged commit 73050bd into stage Nov 16, 2023
11 checks passed
@darwin808 darwin808 deleted the fix/dashboard-input-1 branch November 16, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

website: 🐛 [Bug]: Unnecessary rerenders of components in dashboard when typing
1 participant