Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(join): error on signup #2115

Merged
merged 2 commits into from
Nov 10, 2023
Merged

fix(join): error on signup #2115

merged 2 commits into from
Nov 10, 2023

Conversation

darwin808
Copy link
Contributor

@darwin808 darwin808 commented Nov 10, 2023

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Closes #2114

Fixes # (issue)
#2114

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Manual Test
  • Unit Test
  • E2E Test

Screenshots / Screen recording

Please add screenshots or recording if applicable

image

Copy link

Pull reviewers stats

Stats of the last 30 days for website:

User Total reviews Time to review Total comments
ardeay 8 13h 1m 9
darwin808 4 19h 2m 0
giseleblair 2 2h 5m 0
b-estevez 1 6m 0

@github-actions github-actions bot added the e2e label Nov 10, 2023
@darwin808 darwin808 changed the title fix(join): #2114 fix(join): error on signup Nov 10, 2023
@darwin808 darwin808 requested review from ardeay and gtllien November 10, 2023 14:03
Copy link

@gtllien gtllien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified fix - timer set extended for popup error message

@ardeay ardeay merged commit 67716cb into stage Nov 10, 2023
12 checks passed
@darwin808 darwin808 deleted the fix/join branch January 10, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

website: 🐛 [Bug]: zesty.io/join pop-up error message disappears almost instantly
3 participants