Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roi calculator #2070

Merged
merged 162 commits into from
Oct 24, 2023
Merged

Roi calculator #2070

merged 162 commits into from
Oct 24, 2023

Conversation

jomarmontuya
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list the simulator and android emulators used.

  • Manual Test
  • Unit Test
  • E2E Test

Screenshots / Screen recording

Please add screenshots or recording if applicable

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for website:

User Total reviews Time to review Total comments
ardeay 6 12h 4m 7
giseleblair 4 1d 2h 23m 0
darwin808 2 8d 22h 6m 3
b-estevez 1 6m 0
jomarmontuya 1 1h 39m 0

@darwin808 darwin808 deleted the roi-calculator branch January 12, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants