Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage cms #2029

Merged
merged 12 commits into from
Oct 12, 2023
Merged

Homepage cms #2029

merged 12 commits into from
Oct 12, 2023

Conversation

jomarmontuya
Copy link
Contributor

@jomarmontuya jomarmontuya commented Oct 3, 2023

Description

Connect the homepage back to CMS

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list the simulator and android emulators used.

  • Manual Test

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Pull reviewers stats

Stats of the last 30 days for website:

User Total reviews Time to review Total comments
ardeay 10 1h 23m 1
giseleblair 6 3h 18m 0
jomarmontuya 1 1h 39m 0
darwin808 1 1m 0

@jomarmontuya jomarmontuya marked this pull request as ready for review October 4, 2023 13:27
@jomarmontuya
Copy link
Contributor Author

@ardeay This is ready, tested on both, prod and stage environment

@jomarmontuya
Copy link
Contributor Author

Sync and Tested with next13

supportingText: content?.security_feature_supporting_text,
image: content?.security_feature_image?.data?.[0]?.url,
};

return (
<>
<ThemeProvider theme={() => revampTheme(palette.mode)}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 themeproviders ?

width={'100%'}
height={'100%'}
/>
<img src={heroImage} alt={generateAlt('Zesty image')} loading="eager" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

widht and ht?

@@ -74,6 +74,11 @@ const GetDemoSection = dynamic(() => import('revamp/ui/GetDemoSection'), {
loading: () => <p>Loading...</p>,
});

export const removeHTMLtags = (str) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this in utils file we can use it later

@giseleblair giseleblair merged commit 574b23c into stage Oct 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants