Permet la gestion de contributeurs sur les billets #6551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arnaud-D
added
C-Back
Arnaud-D
force-pushed
the
permet-contributeurs-billets
branch
3 times, most recently
from
38c735b to
dba1872
Compare
philippemilink
requested changes
Nov 1, 2023
Comment on lines
66
to
71
| types = ["TUTORIAL", "ARTICLE", "OPINION"] | ||
| for type in types: | ||
| self.content.type = type | ||
| self.content.save() | ||
| response = self.client.post(self.form_url, self.form_data) | ||
| self.assertRedirects(response, self.content_url) |
There was a problem hiding this comment.
Suggested change
| types = ["TUTORIAL", "ARTICLE", "OPINION"] | |
| for type in types: | |
| self.content.type = type | |
| self.content.save() | |
| response = self.client.post(self.form_url, self.form_data) | |
| self.assertRedirects(response, self.content_url) | |
| for type in CONTENT_TYPE_LIST: | |
| with self.subTest(type): | |
| self.content.type = type | |
| self.content.save() | |
| response = self.client.post(self.form_url, self.form_data) | |
| self.assertRedirects(response, self.content_url) |
En rajoutant
from zds.tutorialv2.models import CONTENT_TYPE_LISTComme ça, le jour où on rajoute un autre type de contenu, ce sera transparent. Le subTest permet de voir plus facilement quel cas fait planter le test.
There was a problem hiding this comment.
Bonne idée, c'est fait.
Arnaud-D
force-pushed
the
permet-contributeurs-billets
branch
from
dba1872 to
f90fb4d
Compare
Arnaud-D
force-pushed
the
permet-contributeurs-billets
branch
from
f90fb4d to
edab932
Compare
Arnaud-D
force-pushed
the
permet-contributeurs-billets
branch
from
edab932 to
cacbf5a
Compare
Arnaud-D
force-pushed
the
permet-contributeurs-billets
branch
3 times, most recently
from
64a7c95 to
911a76a
Compare
Arnaud-D
force-pushed
the
permet-contributeurs-billets
branch
from
911a76a to
631c430
Compare
Arnaud-D
force-pushed
the
permet-contributeurs-billets
branch
2 times, most recently
from
e82d5ff to
4a0ce89
Compare
Arnaud-D
force-pushed
the
permet-contributeurs-billets
branch
from
4a0ce89 to
e77c2d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permet la gestion (ajout, suppression) des contributeurs sur les billets. Encore une partie du découpage de #6441.
On voit que la refactorisation des templates de publication porte ses fruits. La partie template a pu être gérée en modifiant une seule ligne de configuration.
Contrôle qualité
Créer des billets et jouer avec les contributeurs.
Constater qu'ils sont bien ajoutés, supprimés.
Constater qu'ils sont bien affichés comme sur les autres contenus.