Adjust reap interval based on timeouts #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardcoded reap interval of 1 second causes evasive/silent/expired timeouts of less than 1 second to be completely ineffective. Choose the smallest timeout for reap interval instead and only use the hardcoded value as the maximum reap interval when big timeouts are being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current hardcoded reap interval of 1 second causes evasive/silent/expired timeouts of less than 1 second to be completely ineffective since the timeouts are checked anyway at every reap interval.
This PR changes it so that it uses the smallest of the timeouts for reap interval instead and only uses the hardcoded value as the maximum reap interval when big timeouts are being used, thus not breaking the backwards compatibility but allowing small timeouts to work as expected.
Also added a test case which tests the basic functionality of the EVASIVE timeout.