Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate from zproject #740

Closed
wants to merge 1 commit into from
Closed

Regenerate from zproject #740

wants to merge 1 commit into from

Conversation

benjdero
Copy link
Member

@benjdero benjdero commented Aug 2, 2024

No description provided.

@sphaero
Copy link
Contributor

sphaero commented Aug 5, 2024

could you try to delete the .github/workflows/CI.yaml to regenerate it?

Not sure if it works but it might fix the macos build issues

@benjdero benjdero force-pushed the master branch 2 times, most recently from dd1767a to 90ec613 Compare August 5, 2024 13:19
@benjdero
Copy link
Member Author

benjdero commented Aug 5, 2024

It still fails after forcing CI.yaml to regenerate.

@sphaero
Copy link
Contributor

sphaero commented Aug 6, 2024

yes but at least it runs now and is giving a sane error.

  * zyre-curve: D: 24-08-05 13:21:22 (node6) cannot connect to endpoint=tcp://(null):49152
Assertion failed: (msg), function zyre_test, file zyre.c, line 1107.

Apparently zyre doesn't run on MacOS currently. Build also fails on Windows during czmq build.

@sphaero
Copy link
Contributor

sphaero commented Aug 8, 2024

why did you undo the changes? Or did I miss something?

@benjdero
Copy link
Member Author

benjdero commented Sep 6, 2024

Hi @sphaero ,

What can I do to help this PR get merged?

@sphaero
Copy link
Contributor

sphaero commented Sep 6, 2024

You need to include all the files generated by zproject (git status shows which) and rebuild the .github/workflows/CI.yaml like you did before. The project is very outdated I believe

@sphaero
Copy link
Contributor

sphaero commented Sep 10, 2024

@benjdero I've created a new PR #742 which includes all files and fixes. Perhaps you can merge that?

@benjdero
Copy link
Member Author

I don't have permissions to merge on this repository.

@benjdero
Copy link
Member Author

Closing since those changes are embedded into #742

@benjdero benjdero closed this Sep 10, 2024
@sphaero
Copy link
Contributor

sphaero commented Sep 10, 2024

I can give you permission if you want. Just follow C4
I can't merge either

@sphaero
Copy link
Contributor

sphaero commented Sep 10, 2024

I've added you to the maintainers. In the meantime @bluca already merged #742.

@benjdero
Copy link
Member Author

Yeah, I was reading C4 to make sure everything was alright before I approve it but @bluca was faster. Maybe next time! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants