Build zeroMq v5 on Electron 9 - Windows #445
Conversation
|
@rolftimmermans Given the slow process of reviewing #444, I decided to at least fix building v5. Please release a new v5 version after merging this. |
| @@ -29,7 +28,7 @@ | |||
| ['OS=="mac" or OS=="solaris"', { | |||
| 'xcode_settings': { | |||
| 'GCC_ENABLE_CPP_EXCEPTIONS': 'YES', | |||
| 'MACOSX_DEPLOYMENT_TARGET': '10.9', | |||
| 'MACOSX_DEPLOYMENT_TARGET': '10.15', | |||
There was a problem hiding this comment.
What's the reason for bumping this?
There was a problem hiding this comment.
I am not on Mac myself but I've been using this target in Zadeh, and I haven't had any complaints from the users. If we could remove this variable and let Node-gyp handle it for us, it would be awesome.
There was a problem hiding this comment.
I'll try this locally on my Mac to confirm. Might as well dust off the old zeromq.js set up as well.
|
Could you do that? The flood of error messages from the users has started. |
|
It's released now. |
|
@captainsafia did you create a GitHub tag? The prebuilds are not uploaded yet. Since this package used prebuild-install the existence of the prebuilds rely on the GitHub tag |
|
The Github tag is created But the prebuilds are not uploaded yet. Did Travis and Appveyor run on the tag creation? It seems the deploy tasks have failed: https://ci.appveyor.com/project/zeromq/zeromq-js/builds/38706697 |
Closes #439