Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build with cmake (scikit-build-core) #1927

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Feb 14, 2024

seems to have been a lot easier than meson in #1922. I'm not great at cmake, but since libzmq uses it, integration was easier.

closes #1922
closes #1903

@minrk minrk changed the title build with scikit-build-core build with scikit-build-core (cmake) Feb 14, 2024
@minrk minrk marked this pull request as draft February 14, 2024 23:46
@minrk minrk force-pushed the scikit-build-core branch 3 times, most recently from 5231661 to 45e67dc Compare February 15, 2024 19:55
@minrk minrk changed the title build with scikit-build-core (cmake) build with cmake (scikit-build-core) Feb 16, 2024
libzmq no longer supports binaries for Windows,
and has removed support for tweetnacl.

This may mean that Windows wheels will lose CURVE.
@minrk minrk force-pushed the scikit-build-core branch 2 times, most recently from 4f29e7d to 94248a3 Compare February 16, 2024 08:57
@minrk minrk marked this pull request as ready for review February 16, 2024 09:55
@minrk minrk force-pushed the scikit-build-core branch 2 times, most recently from b37fbb1 to 868f900 Compare February 16, 2024 10:34
@minrk minrk merged commit ecf6db5 into zeromq:main Feb 16, 2024
29 checks passed
@minrk minrk deleted the scikit-build-core branch February 16, 2024 13:51
@dimpase
Copy link

dimpase commented Jun 5, 2024

this seems to be breaking SageMath build, as scikit does something something ... cschwan/sage-on-gentoo#783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants