Unnecessary dynamic memory allocation in zmq_poller_poll() #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_poller_poll(). Fixed by allocating zmq::socket_poller_t from stack.
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running
asyncsrv.cppC++ example on Windows, CPU usage is high.CPU profiling in VS2015 Community shows that there are a lot of malloc/free operations done in
zmq::poll()andzmq::proxy_steerable(). Most of malloc/free allocations are inzmq_poller_poll(), with new/delete.This change removes unnecessary new/delete for
zmq::socket_poller_tinzmq_poller_poll().However, this needs further improvement for
zmq_poller_event_t *events;.