feat/custom_buckets #4313
Open
feat/custom_buckets #4313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
Closed
added 2 commits
August 19, 2024 12:33
kevwan
force-pushed
the
feat/custom_buckets
branch
from
31a4613
to
f89dbd7
Compare
kevwan
reviewed
Aug 28, 2024
| @@ -219,6 +219,13 @@ func WithMaxBytes(maxBytes int64) RouteOption { | |||
| } | |||
| } | |||
|
|
|||
| // WithMetricsReqDurBuckets returns a RouteOption to set metrics request duration buckets. | |||
| func WithMetricsReqDurBuckets(buckets []float64) RouteOption { | |||
There was a problem hiding this comment.
Define buckets for each route?
|
Any progress? I am waiting for this feature. @MarkJoyMa @kevwan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rest server, zrpc client\server support custom settings Prometheus ReqDurBuckets