Fix bogus disconnected check #3402
Merged
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
commented
Jan 22, 2025
| @@ -606,16 +606,16 @@ SessionI::disconnected(const ConnectionPtr& connection, exception_ptr ex) | |||
| // Ignore already destroyed. | |||
| return false; | |||
| } | |||
| else if (connection && _connection != connection) | |||
| { | |||
| // Ignore the session has already reconnected using a new connection. | |||
There was a problem hiding this comment.
It is incorrect to check this before verifying if the session is disconnected.
If _session is nullptr because the session is disconnected, we can still receive a disconnected request on a new connection from a failing recovery attempt. In other words, this connection comparison does not ensure that the session has reconnected.
externl
approved these changes
Jan 22, 2025
bernardnormier
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.