Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ICE_BUILDING_xxx macros, streamline Config.h #3398

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Remove ICE_BUILDING_xxx macros, streamline Config.h #3398

merged 3 commits into from
Jan 21, 2025

Conversation

bernardnormier
Copy link
Member

This PR removes a number of ICE_BUILDING_xxx macros and streamlines the Xxx/Config.h.

Most of these Config.h are included in generated headers and used to automatically link the corresponding "stub" library on Windows.

After this PR, there are 4 remaining ICE_BUILDING_xxx macros:

  • ICE_BUILDING_SLICE_COMPILERS - Windows only, used by the C++ build
  • ICE_BUILDING_GENERATED_CODE - to reduce headers included in generated .cpp
  • ICE_BUILDING_ICE and ICE_BUILDING_ICE_LOCATOR_DISCOVERY - used by the Python build, possibly only on Windows. Would be nice to review/remove in a follow-up PR.

externl
externl approved these changes Jan 21, 2025
View reviewed changes
cpp/include/Glacier2/Config.h Outdated Show resolved Hide resolved
@bernardnormier bernardnormier merged commit d5bb07d into zeroc-ice:main Jan 21, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@externl externl externl approved these changes

@pepone pepone pepone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bernardnormier @pepone @externl