Remove protected metadata #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
approved these changes
Jan 20, 2025
| @@ -61,15 +61,15 @@ class D | |||
| bool postUnmarshalInvoked; | |||
| } | |||
|
|
|||
| ["protected"] class E | |||
There was a problem hiding this comment.
We should remove these tests since they were apparently all about testing protected.
| @@ -149,7 +149,7 @@ exception RequiredException extends OptionalException | |||
| class OptionalWithCustom | |||
| { | |||
| optional(1) SmallStructList l; | |||
| ["protected"] optional(2) SmallStructList lp; | |||
There was a problem hiding this comment.
Same here. lp is the same as l (great name) except protected.
InsertCreativityHere
approved these changes
Jan 20, 2025
| @@ -2258,55 +2258,15 @@ Slice::Gen::DataDefVisitor::visitClassDefEnd(const ClassDefPtr& p) | |||
|
|
|||
| // Emit data members. Access visibility may be specified by metadata. | |||
| const DataMemberList dataMembers = p->dataMembers(); | |||
| const bool prot = p->hasMetadata("protected"); | |||
| bool inProtected = false; | |||
| bool needSp = true; | |||
There was a problem hiding this comment.
What does the formatting look like without needSp?
It seems like this field was for emitting a newline before the first data member, more than it was for protected stuff.
Co-authored-by: Austin Henriksen <[email protected]>
Co-authored-by: Austin Henriksen <[email protected]>
Co-authored-by: Austin Henriksen <[email protected]>
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3360