Move IAP EndpointInfo and ConnectionInfo #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Nov 26, 2024
| * Provides access to the connection details of an IAP connection | ||
| * \headerfile Ice/Ice.h | ||
| */ | ||
| class IAPConnectionInfo final : public ConnectionInfo |
There was a problem hiding this comment.
I didn't update the Swift code yet even though this renaming makes an update necessary.
I am curious to see if the Swift CI will fail.
There was a problem hiding this comment.
Seems we are not building for iOS, there is some commented out code in the ci workflow:
Lines 55 to 62 in 8c76edb
| @@ -383,9 +383,9 @@ - (void)stream:(NSStream*)stream handleEvent:(NSStreamEvent)eventCode | |||
| IceObjC::iAPTransceiver::getInfo(bool incoming, string adapterName, string connectionId) const | |||
| { | |||
| assert(!incoming); | |||
| assert(adapterName.empty()); | |||
pepone
approved these changes
Nov 27, 2024
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the IAP EndpointInfo and ConnectionInfo definitions to namespace Ice.
It also makes them available all the time - not just for iOS. These are tiny classes, there is no real benefit in ifdefing them out.