Move Timer to IceInternal, add InlineTimerTask #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Oct 17, 2024
| @@ -43,6 +55,13 @@ namespace Ice | |||
| // Destroy the timer and join the timer execution thread. Must not be called from a timer task. | |||
| void destroy(); | |||
|
|
|||
| // Schedule a function-task for execution after a given delay. | |||
| template<class Rep, class Period> | |||
| void schedule(std::function<void()> function, const std::chrono::duration<Rep, Period>& delay) | |||
There was a problem hiding this comment.
In the original DataStorm Timer API, schedule returned a "cancel" function. This supports cancellation while storing std::function.
We could refactor IceInternal::Timer to use this old DataStorm API but it would be much more work. And it would be difficult to implement isScheduled.
externl
approved these changes
Oct 17, 2024
pepone
approved these changes
Oct 17, 2024
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2877.