Disable relational operators for classes and exceptions C++ #2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Oct 7, 2024
| * @param lhs The left-hand side. | ||
| * @param rhs The right-hand side. | ||
| * @return True if the left-hand side compares less than the right-hand side, false otherwise. | ||
| */ | ||
| template< | ||
| class C, | ||
| std::enable_if_t<std::is_member_function_pointer<decltype(&C::ice_tuple)>::value, bool> = true> | ||
| std::enable_if_t< | ||
| std::is_member_function_pointer<decltype(&C::ice_tuple)>::value && !std::is_polymorphic_v<C>, |
There was a problem hiding this comment.
classes and exceptions are polymorphic, while structs aren't.
| @@ -105,24 +105,24 @@ allTests(Test::TestHelper* helper) | |||
| Test::CPtr c1 = make_shared<Test::C>(s1); | |||
| { | |||
| auto result = i->opCAsync(c1).get(); | |||
| test(Ice::targetEqualTo(std::get<0>(result), c1)); | |||
| test(Ice::targetEqualTo(std::get<1>(result), c1)); | |||
| test(std::get<0>(result)->ice_tuple() == c1->ice_tuple()); | |||
There was a problem hiding this comment.
If you need/want these comparisons, you can compare the tuples. Or you can write your own relational operators that compare the tuples (+ ice_id() and more, it's up to you).
pepone
approved these changes
Oct 7, 2024
externl
approved these changes
Oct 7, 2024
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
…ses and exceptions (zeroc-ice/ice#2862)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the relational operators for classes and exceptions in C++.
Prior to this PR, they were enabled and implemented using ice_tuple, we could lead to unexpected results, in particular two classes with different types could compare equal (since the comparison slices to the common base type).