Fail on unknown properties #2837
Conversation
| message.Append(prefix.AsSpan(0, prefix.Length - 1)); | ||
| message.Append("':"); | ||
| foreach (string p in unknownProps) | ||
| { | ||
| message.Append("\n "); | ||
| message.Append(p); | ||
| } | ||
| Ice.Util.getProcessLogger().warning(message.ToString()); | ||
| throw new InvalidOperationException(message.ToString()); |
There was a problem hiding this comment.
Not clear what is the more appropriate exception here, this can be called from the dispatch when metrics are updated using the metrics admin facet.
There was a problem hiding this comment.
It should be a LocalException since we have a lot of code that expects only LocalException.
| { | ||
| var initData = new InitializationData(); | ||
| initData.properties = createTestProperties(ref args); | ||
| using (var communicator = initialize(initData)) |
| message.Append(prefix.AsSpan(0, prefix.Length - 1)); | ||
| message.Append("':"); | ||
| foreach (string p in unknownProps) | ||
| { | ||
| message.Append("\n "); | ||
| message.Append(p); | ||
| } | ||
| Ice.Util.getProcessLogger().warning(message.ToString()); | ||
| throw new InvalidOperationException(message.ToString()); |
There was a problem hiding this comment.
It should be a LocalException since we have a lot of code that expects only LocalException.
| message.Append(prefix); | ||
| message.Append("':"); | ||
| foreach (string s in unknownProps) | ||
| { | ||
| message.Append("\n "); | ||
| message.Append(s); | ||
| } | ||
| _instance.initializationData().logger.warning(message.ToString()); | ||
| throw new InitializationException(message.ToString()); |
There was a problem hiding this comment.
I don't think it's the right exception, and it can occur after communicator/OA initialization.
For now, I'm just replacing the usage of |
This is the C# side of #2799