Add support for multi platform xcframeworks #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
approved these changes
Aug 29, 2024
pepone
approved these changes
Aug 29, 2024
|
I've updated the build to include iAP in Ice. This simplifies the Swift build dependencies. |
bernardnormier
approved these changes
Sep 3, 2024
cpp/src/Ice/Makefile.mk
Outdated
| @@ -28,7 +28,8 @@ endif | |||
| endif | |||
|
|
|||
| Ice[iphoneos]_excludes := $(wildcard src/Ice/CtrlCHandler.cpp $(addprefix $(currentdir)/,Tcp*.cpp Service.cpp)) | |||
| Ice[iphoneos]_extra_sources := $(wildcard $(addprefix $(currentdir)/ios/,*.cpp *.mm)) | |||
| Ice[iphoneos]_extra_sources := $(wildcard $(addprefix $(currentdir)/ios/,*.cpp *.mm))\ | |||
| $(wildcard $(addprefix $(currentdir)/iAP/,*.cpp *.mm)) | |||
There was a problem hiding this comment.
I think it would be cleaner to add an iAP prefix to all iAP source files and then move them to the ios folder. It's odd to have src/Ice/ios and src/Ice/iAP that are both ios-only.
bernardnormier
approved these changes
Sep 4, 2024
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for creating multi-platform xcframeworks. We bundle all static libraries for the platforms specified in PLATFORMS.