Rework proxy creation in Ruby #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Jul 11, 2024
| @@ -5,7 +5,7 @@ | |||
| def batchOneways(p) | |||
| bs1 = "\0" * (10 * 1024); | |||
|
|
|||
| batch = Test::MyClassPrx::uncheckedCast(p.ice_batchOneway()) | |||
| batch = p.ice_batchOneway() | |||
There was a problem hiding this comment.
Proxy factory methods in Ruby preserve types, but the tests didn't know it?
| @@ -1150,9 +1150,13 @@ IceRuby_ObjectPrx_ice_staticId(VALUE /*self*/) | |||
| } | |||
|
|
|||
| extern "C" VALUE | |||
| IceRuby_ObjectPrx_new(int /*argc*/, VALUE* /*args*/, VALUE /*self*/) | |||
| IceRuby_ObjectPrx_new(VALUE self, VALUE communicator, VALUE proxyString) | |||
There was a problem hiding this comment.
The method was already provided, but not implemented!
pepone
approved these changes
Jul 13, 2024
We typically check the number of arguments and their types for such methods. |
I'll look into it in a follow-up PR. |
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows you to create a proxy with simply
FooBarPrx.new(communicator, proxyString)in Ruby.It also updates the tests to:
newNote that since Ruby doesn't support method overloading, we can't use new as an alias for uncheckedCast. So uncheckedCast stays.