Implement connect timeout & close timeout in Java, remove connection timeouts #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Jun 19, 2024
| @@ -2,230 +2,226 @@ | |||
|
|
|||
| using System.Diagnostics; | |||
|
|
|||
| namespace Ice | |||
| namespace Ice.timeout; | |||
There was a problem hiding this comment.
Just updated the namespace in this file.
|
|
||
| TimeoutPrx timeout = TimeoutPrx.checkedCast(obj); | ||
| test(timeout != null); | ||
| TimeoutPrx timeout = TimeoutPrx.uncheckedCast(communicator.stringToProxy(sref)); |
There was a problem hiding this comment.
To be replaced by createProxy.
pepone
approved these changes
Jun 20, 2024
| _removeFromFactory = removeFromFactory; | ||
| _warn = initData.properties.getIcePropertyAsInt("Ice.Warn.Connections") > 0; | ||
| _warnUdp = | ||
| instance.initializationData().properties.getIcePropertyAsInt("Ice.Warn.Datagrams") > 0; | ||
| _cacheBuffers = instance.cacheMessageBuffers(); |
There was a problem hiding this comment.
It was no longer used.
The previous dispatch pipeline removed all dispatch-side caching.
| } | ||
| out.println("ok"); | ||
|
|
||
| out.print("testing close timeout... "); | ||
| out.flush(); | ||
| { | ||
| TimeoutPrx to = TimeoutPrx.uncheckedCast(obj.ice_timeout(250 * mult)); | ||
| com.zeroc.Ice.Connection connection = connect(to); | ||
| var connection = connect(timeout); |
There was a problem hiding this comment.
Do we need to use the connect wrapper, we now have 1s connect timeout.
There was a problem hiding this comment.
Removed. Note that this is not a great test - it doesn't test the CloseTimeout.
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
…eout in Java, remove connection timeouts (zeroc-ice/ice#2321)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement ConnectTimeout and CloseTimeout in Java, and also removes connection timeouts (like already done in C# and C++).