Remove ACM properties #2318
Remove ACM properties #2318
Conversation
js/src/Ice/PropertyNames.js
Outdated
| @@ -46,7 +29,7 @@ PropertyNames.IceProps = [ | |||
| new Property("Ice.Admin.Locator.Locator", false, "", false), | |||
| new Property("Ice.Admin.Locator.Router", false, "", false), | |||
| new Property("Ice.Admin.Locator.CollocationOptimized", false, "", false), | |||
| new Property("^Ice.Admin.Locator.Context..", true, "", false), | |||
| new Property("^Ice\.Admin\.Locator\.Context\..", true, "", false), | |||
There was a problem hiding this comment.
It's not clear to me why this regeneration added these escapes.
There was a problem hiding this comment.
The escapes look correct, if I recall correctly Joe committed a fix for the handling of regexp in JavaScript.
There was a problem hiding this comment.
For what it's worth, the escapes are always added by the script,
but Prettier removed them when JS got reformatted.
There was a problem hiding this comment.
Actually, if we want to escape the dot, shouldn't it be \\., otherwise \. is just .
I guess the best is to create a separate issue, it seems unrelated to the PR.
js/src/Ice/PropertyNames.js
Outdated
| export const PropertyNames = {}; | ||
| PropertyNames.IceProps = [ | ||
| PropertyNames.IceProps = |
There was a problem hiding this comment.
You can run npx prettier --write src/Ice/PropertyNames.js in js to reformat this file. I didn't have time to add the style checker to CI yet.
This PR removes all the ACM properties.