Remove ACM in JavaScript #2312
Merged
Remove ACM in JavaScript #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
approved these changes
Jun 18, 2024
| @@ -527,7 +433,7 @@ export class ConnectionI { | |||
| sendNoResponse() { | |||
| Debug.assert(this._state > StateNotValidated); | |||
| try { | |||
| if (--this._dispatchCount === 0) { | |||
| if (--this._upcallCount === 0) { | |||
There was a problem hiding this comment.
You're still calling reap() (removed method) in the code below.
js/src/Ice/ConnectionI.js
Outdated
| if (this._state === StateFinished) { | ||
| this.reap(); | ||
| if (this._removeFromFactory !== null) { |
There was a problem hiding this comment.
I believe _removeFromFactory is always non-null in JS.
There was a problem hiding this comment.
In other languages, it's null only for incoming UDP connections.
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ACM in JavaScript - Similar to C# #2202