JavaScript build cleanup & simplifications #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
requested review from
InsertCreativityHere
and removed request for
ReeceHumphreys
bernardnormier
approved these changes
Jun 19, 2024
InsertCreativityHere
approved these changes
Jun 19, 2024
js/gulpfile.js
Outdated
| deleteAsync(libGeneratedFiles(lib, sources)); | ||
| cb(); | ||
| }); | ||
| const slicePatterns = [`../slice/${lib}/*.ice`, ...(excludes[lib] || [])]; |
There was a problem hiding this comment.
Could we move this const up to the top, since it looks like we repeat this string in the above block.
js/gulpfile.js
Outdated
| pump( | ||
| [ | ||
| gulp.src(sources.slice.map(sliceFile)), | ||
| gulp.src([`../slice/${lib}/*.ice`, ...(excludes[lib] || [])]), |
|
|
||
| gulp.task( | ||
| "test:clean", | ||
| gulp.series( |
There was a problem hiding this comment.
Very minor, but why switch the cleaning from parallel to series?
More consistent with the other tasks we define I guess?
I'm not against it, just curious.
There was a problem hiding this comment.
We got a few out of memory errors in GitHub Action workers
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleanups and simplifies the JavaScript build