Fix for #1543 #1905
Merged
Fix for #1543 #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
approved these changes
Mar 6, 2024
| @@ -19,7 +18,7 @@ class ClientPermissionsVerifierI final : public Glacier2::PermissionsVerifier | |||
| { | |||
| if(current.ctx.find("throw") != current.ctx.end()) | |||
| { | |||
| throw Test::ExtendedPermissionDeniedException("reason"); | |||
| throw Glacier2::PermissionDeniedException("reason"); | |||
There was a problem hiding this comment.
For my understanding:
using a derived exception no longer works for this use-case because the intermediary (IceGrid) unmarshals and then remarshals the exception?
pepone
approved these changes
Mar 6, 2024
cpp/include/Ice/Value.h
Outdated
|
|
||
| private: | ||
|
|
||
| ::std::shared_ptr<Ice::SlicedData> _slicedData; |
There was a problem hiding this comment.
minor: use SliceDataPtr like above:
Suggested change
| ::std::shared_ptr<Ice::SlicedData> _slicedData; | |
| SlicedDataPtr _slicedData; |
I couldn't find metadata validation for preserve-slice. |
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1543 for all language mappins except Matlab. I can try to write a patch for Matlab to make it easier to fix it but I won't be able to test.