Ran autopep8 #1698
Ran autopep8 #1698
Conversation
|
I think we should be formatting and linting with Ruff https://docs.astral.sh/ruff/. It seems like it has taken off over the past few years and is generally the recommended tool for Python formatting and linting. It is basically a drop in replacement for the Flake8 + Black + isort + ... python linting and formatting toolchain. I have been testing it locally for the past few days on the metrics project and it is considerably faster than those other tools too! |
Definitely something we can look into once the baseline linting is done! |
| Glacier2StaticFilteringTestSuite(__name__, testcases=[], runOnMainThread=True, options={ "ipv6" : [False] }, multihost=False) | ||
|
|
||
| Glacier2StaticFilteringTestSuite(__name__, testcases=[], runOnMainThread=True, | ||
| options={"ipv6": [False]}, multihost=False) |
There was a problem hiding this comment.
Is this configurable? I prefer one parameter per line when we have to split a long line.
There was a problem hiding this comment.
For now I think we should just to the defaults. Once all the linting is done we can go back and tweak the style if we really want to.
| if isinstance(platform, Windows) or os.getuid() != 0: | ||
| TestSuite(__file__, [IceGridUpdateTestCase(application=None, client=IceGridClient(props=clientProps))], multihost=False) | ||
| TestSuite(__file__, [IceGridUpdateTestCase(application=None, | ||
| client=IceGridClient(props=clientProps))], multihost=False) |
There was a problem hiding this comment.
I don't like this formatting very much
TestSuite(__file__,
[IceGridUpdateTestCase(application=None, client=IceGridClient(props=clientProps))],
multihost=False)
seems more natural
There was a problem hiding this comment.
For now I think we should just to the defaults. Once all the linting is done we can go back and tweak the style if we really want to.
I ran autopep8 over the all the python files. It only performs non-breaking changes. In a follow-up PR I plan to do more of the manual lints.