Skip to content

Commit

Permalink
Disable debug Swift Ice/optional test (#2640)
Browse files Browse the repository at this point in the history
  • Loading branch information
externl authored Aug 9, 2024
1 parent ff60229 commit 79f32f4
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
config: "debug"
build_flags: "OPTIMIZE=no"
# https://github.com/zeroc-ice/ice/issues/2061
test_flags: "--swift-config=debug --rfilter=csharp/Ice/adapterDeactivation"
test_flags: "--swift-config=debug --rfilter=csharp/Ice/adapterDeactivation --rfilter=swift/Ice/optional"
- os: ubuntu-24.04
config: "debug"
build_flags: "OPTIMIZE=no"
Expand Down
12 changes: 11 additions & 1 deletion swift/test/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,18 @@ func testPathToTargetName(_ path: String) -> String {
return path.replacingOccurrences(of: "/", with: "_")
}

func filterDebugTest(_ key: String, _ value: TestConfig) -> Bool {
let skipDebugTests = [
// "Ice/operations",
"Ice/optional"
]
let debugBuild = ProcessInfo.processInfo.environment["OPTIMIZE"] == "no"

return !debugBuild || !skipDebugTests.contains(key)
}

var testDriverDependencies = [Target.Dependency]()
let testTargets = testDirectories.map { (testPath, testConfig) in
let testTargets = testDirectories.filter(filterDebugTest).map { (testPath, testConfig) in

var targets = [Target]()

Expand Down

0 comments on commit 79f32f4

Please sign in to comment.