Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/main' into x-js-optionals
Browse files Browse the repository at this point in the history
  • Loading branch information
pepone committed Jun 26, 2024
2 parents f81a80e + b3fa58c commit 691e67b
Show file tree
Hide file tree
Showing 207 changed files with 1,095 additions and 1,162 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

#include <Ice/Ice.h>
// Disable deprecation warnings from SecureTransport APIs
#include "../../src/IceUtil/DisableWarnings.h"
#include "../../src/Ice/DisableWarnings.h"

#if defined(ICE_USE_SECURE_TRANSPORT)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

#include <Ice/Ice.h>
// Disable deprecation warnings from SecureTransport APIs
#include "../../src/IceUtil/DisableWarnings.h"
#include "../../src/Ice/DisableWarnings.h"

#if defined(ICE_USE_SECURE_TRANSPORT)
void
Expand Down
9 changes: 4 additions & 5 deletions cpp/src/Glacier2/Glacier2Router.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
// Copyright (c) ZeroC, Inc. All rights reserved.
//

#include "../IceUtil/ConsoleUtil.h"
#include "../IceUtil/Options.h"
#include "../Ice/ConsoleUtil.h"
#include "../Ice/Options.h"
#include "Glacier2/NullPermissionsVerifier.h"
#include "Glacier2/Session.h"
#include "Ice/Ice.h"
Expand All @@ -15,7 +15,6 @@ using namespace std;
using namespace Ice;
using namespace Glacier2;
using namespace IceInternal;
using namespace IceUtilInternal;

namespace
{
Expand Down Expand Up @@ -92,7 +91,7 @@ RouterService::start(int argc, char* argv[], int& status)
{
bool nowarn;

IceUtilInternal::Options opts;
IceInternal::Options opts;
opts.addOpt("h", "help");
opts.addOpt("v", "version");
opts.addOpt("", "nowarn");
Expand All @@ -102,7 +101,7 @@ RouterService::start(int argc, char* argv[], int& status)
{
args = opts.parse(argc, argv);
}
catch (const IceUtilInternal::BadOptException& e)
catch (const IceInternal::BadOptException& e)
{
error(e.reason);
usage(argv[0]);
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/Glacier2/Glacier2Router.rc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "../IceUtil/ResourceConfig.h"
#include "../Ice/ResourceConfig.h"

#define ICE_INTERNALNAME "glacier2router\0"
#define ICE_ORIGINALFILENAME "glacier2router.exe\0"
Expand Down
3 changes: 1 addition & 2 deletions cpp/src/Glacier2/ProxyVerifier.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
//

#include "ProxyVerifier.h"
#include "../IceUtil/ConsoleUtil.h"
#include "../Ice/ConsoleUtil.h"

#include <stdexcept>
#include <string>
Expand All @@ -12,7 +12,6 @@
using namespace std;
using namespace Ice;
using namespace IceInternal;
using namespace IceUtilInternal;

//
// TODO: Some of the address matching helper classes can probably be
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "../IceUtil/ResourceConfig.h"
#include "../Ice/ResourceConfig.h"

#define ICE_INTERNALNAME ICE_LIBNAME("glacier2cryptpermissionsverifier") "\0"
#define ICE_ORIGINALFILENAME ICE_LIBNAME("glacier2cryptpermissionsverifier") ".dll\0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#include "Glacier2/PermissionsVerifier.h"
#include "Ice/Ice.h"

#include "../IceUtil/FileUtil.h"
#include "../Ice/FileUtil.h"
#include "Ice/StringUtil.h"

#include <fstream>
Expand All @@ -25,7 +25,7 @@
#endif

// Disable deprecation warnings from CommonCrypto APIs
#include "../IceUtil/DisableWarnings.h"
#include "../Ice/DisableWarnings.h"

using namespace std;
using namespace Ice;
Expand Down Expand Up @@ -68,7 +68,7 @@ namespace

map<string, string> retrievePasswordMap(const string& file)
{
ifstream passwordFile(IceUtilInternal::streamFilename(file).c_str());
ifstream passwordFile(IceInternal::streamFilename(file).c_str());
if (!passwordFile)
{
string err = IceInternal::lastErrorToString();
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/Glacier2Lib/Glacier2.rc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "../IceUtil/ResourceConfig.h"
#include "../Ice/ResourceConfig.h"

#define ICE_INTERNALNAME ICE_LIBNAME("glacier2") "\0"
#define ICE_ORIGINALFILENAME ICE_LIBNAME("glacier2") ".dll\0"
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/Ice/ConnectionFactory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
//

#include "ConnectionFactory.h"
#include "../IceUtil/Random.h"
#include "Acceptor.h"
#include "CommunicatorFlushBatchAsync.h"
#include "ConnectionI.h"
Expand All @@ -16,6 +15,7 @@
#include "Ice/Properties.h"
#include "Instance.h"
#include "ObjectAdapterI.h" // For getThreadPool().
#include "Random.h"
#include "Reference.h"
#include "RouterInfo.h"
#include "ThreadPool.h"
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/Ice/ConnectionI.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
//

#include "ConnectionI.h"
#include "../IceUtil/DisableWarnings.h"
#include "BatchRequestQueue.h"
#include "CheckIdentity.h"
#include "DefaultsAndOverrides.h"
#include "DisableWarnings.h"
#include "Endian.h"
#include "EndpointI.h"
#include "Ice/IncomingRequest.h"
Expand Down
20 changes: 10 additions & 10 deletions cpp/src/IceUtil/ConsoleUtil.cpp → cpp/src/Ice/ConsoleUtil.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
#include <iostream>
#include <mutex>

using namespace IceUtilInternal;
using namespace IceInternal;
using namespace std;

#if defined(_WIN32)
Expand All @@ -24,7 +24,7 @@ namespace
}

const ConsoleUtil&
IceUtilInternal::getConsoleUtil()
IceInternal::getConsoleUtil()
{
lock_guard sync(consoleMutex);
if (consoleUtil == 0)
Expand All @@ -34,8 +34,8 @@ IceUtilInternal::getConsoleUtil()
return *consoleUtil;
}

ConsoleOut IceUtilInternal::consoleOut;
ConsoleErr IceUtilInternal::consoleErr;
ConsoleOut IceInternal::consoleOut;
ConsoleErr IceInternal::consoleErr;

ConsoleUtil::ConsoleUtil()
: _converter(Ice::getProcessStringConverter()),
Expand Down Expand Up @@ -91,15 +91,15 @@ ConsoleUtil::error(const string& message) const
}

ConsoleOut&
IceUtilInternal::endl(ConsoleOut& out)
IceInternal::endl(ConsoleOut& out)
{
fprintf_s(stdout, "\n");
fflush(stdout);
return out;
}

ConsoleOut&
IceUtilInternal::flush(ConsoleOut& out)
IceInternal::flush(ConsoleOut& out)
{
fflush(stdout);
return out;
Expand All @@ -113,15 +113,15 @@ ConsoleOut::operator<<(ConsoleOut& (*pf)(ConsoleOut&))
}

ConsoleErr&
IceUtilInternal::endl(ConsoleErr& err)
IceInternal::endl(ConsoleErr& err)
{
fprintf_s(stderr, "\n");
fflush(stderr);
return err;
}

ConsoleErr&
IceUtilInternal::flush(ConsoleErr& err)
IceInternal::flush(ConsoleErr& err)
{
fflush(stderr);
return err;
Expand All @@ -134,6 +134,6 @@ ConsoleErr::operator<<(ConsoleErr& (*pf)(ConsoleErr&))
return *this;
}
#else
std::ostream& IceUtilInternal::consoleOut = cout;
std::ostream& IceUtilInternal::consoleErr = cerr;
std::ostream& IceInternal::consoleOut = cout;
std::ostream& IceInternal::consoleErr = cerr;
#endif
6 changes: 3 additions & 3 deletions cpp/src/IceUtil/ConsoleUtil.h → cpp/src/Ice/ConsoleUtil.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@
// Copyright (c) ZeroC, Inc. All rights reserved.
//

#ifndef ICE_UTIL_CONSOLE_UTIL_H
#define ICE_UTIL_CONSOLE_UTIL_H
#ifndef ICE_CONSOLE_UTIL_H
#define ICE_CONSOLE_UTIL_H

#include "Ice/Config.h"
#include "Ice/StringConverter.h"

#include <ostream>
#include <sstream>

namespace IceUtilInternal
namespace IceInternal
{
#if defined(_WIN32)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
// Copyright (c) ZeroC, Inc. All rights reserved.
//

#ifndef ICE_UTIL_DISABLEWARNINGS_H
#define ICE_UTIL_DISABLEWARNINGS_H
#ifndef ICE_DISABLEWARNINGS_H
#define ICE_DISABLEWARNINGS_H

//
// This header file disables various compiler warnings that we don't want.
Expand Down
Loading

0 comments on commit 691e67b

Please sign in to comment.