Update Swift exceptions to be "@unchecked Sendable" (#2767)

zeroc-ice · Sep 24, 2024 · 5ffe73e · 5ffe73e
1 parent 02738b3
commit 5ffe73e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/cpp/src/slice2swift/Gen.cpp b/cpp/src/slice2swift/Gen.cpp
@@ -393,6 +393,7 @@ Gen::TypesVisitor::visitExceptionStart(const ExceptionPtr& p)
     {
         out << getUnqualified("Ice.UserException", swiftModule);
     }
+    out << ", @unchecked Sendable";
     out << sb;
 
     const DataMemberList members = p->dataMembers();

diff --git a/swift/src/Ice/UserException.swift b/swift/src/Ice/UserException.swift
@@ -1,7 +1,9 @@
 // Copyright (c) ZeroC, Inc.
 
-/// Base class for Ice user exceptions.
-open class UserException: Exception {
+/// Base class for Ice user exceptions. User exceptions are marked as "@unchecked Sendable" as the error
+/// protocol requires them to be Sendable. However, the generated exception classes are not thread safe, and users
+/// should not share instances of user exceptions between threads.
+open class UserException: Exception, @unchecked Sendable {
     public required init() {}
 
     /// Gets the type ID of the class.