review fixes

zeroc-ice · Oct 17, 2024 · 3aa9e0c · 3aa9e0c
1 parent ec2d985
commit 3aa9e0c
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/config/makeprops.py b/config/makeprops.py
@@ -265,7 +265,7 @@ def openFiles(self):
         const int length;
     }};
 
-    class ICE_API PropertyNames
+    class PropertyNames
     {{
     public:
 """)
@@ -280,15 +280,15 @@ class ICE_API PropertyNames
     @override
     def closeFiles(self):
         self.hFile.write(f"""
-        static const std::array<PropertyArray,{len(self.generatedPropertyArrays())}> validProps;
+        static const std::array<PropertyArray, {len(self.generatedPropertyArrays())}> validProps;
     }};
 }}
 
 #endif
 """)
 
         self.cppFile.write(f"""\
-const std::array<PropertyArray,{len(self.generatedPropertyArrays())}> PropertyNames::validProps =
+const std::array<PropertyArray, {len(self.generatedPropertyArrays())}> PropertyNames::validProps =
 {{
     {",\n    ".join([f"{name}Props" for name in self.generatedPropertyArrays()])}
 }};

diff --git a/cpp/src/Ice/MetricsAdminI.cpp b/cpp/src/Ice/MetricsAdminI.cpp
@@ -62,7 +62,7 @@ namespace
             {
                 os << "\n    " << prop;
             }
-            throw UnknownPropertyException(__FILE__, __LINE__, os.str());
+            throw UnknownPropertyException{__FILE__, __LINE__, os.str()};
         }
     }
 

diff --git a/cpp/src/Ice/Properties.cpp b/cpp/src/Ice/Properties.cpp
@@ -60,7 +60,7 @@ namespace
 
         if (!propertyArray)
         {
-            throw UnknownPropertyException(__FILE__, __LINE__, "unknown Ice property: " + string{key});
+            throw UnknownPropertyException{__FILE__, __LINE__, "unknown Ice property: " + string{key}};
         }
 
         // The Ice property prefix.
@@ -70,7 +70,7 @@ namespace
 
         if (!prop)
         {
-            throw UnknownPropertyException(__FILE__, __LINE__, "unknown Ice property: " + string{key});
+            throw UnknownPropertyException{__FILE__, __LINE__, "unknown Ice property: " + string{key}};
         }
 
         return prop->defaultValue;
@@ -319,7 +319,7 @@ Ice::Properties::setProperty(string_view key, string_view value)
         auto prop = IceInternal::findProperty(key.substr(propertyPrefix.length() + 1), *propertyArray);
         if (!prop)
         {
-            throw UnknownPropertyException(__FILE__, __LINE__, "unknown Ice property: " + string{key});
+            throw UnknownPropertyException{__FILE__, __LINE__, "unknown Ice property: " + string{key}};
         }
 
         // If the property is deprecated, log a warning.

diff --git a/cpp/src/Ice/PropertyUtil.cpp b/cpp/src/Ice/PropertyUtil.cpp
@@ -95,6 +95,6 @@ IceInternal::validatePropertiesWithPrefix(
             os << "\n    " << prop;
         }
 
-        throw UnknownPropertyException(__FILE__, __LINE__, os.str());
+        throw UnknownPropertyException{__FILE__, __LINE__, os.str()};
     }
 }
diff --git a/cpp/src/Ice/PropertyUtil.h b/cpp/src/Ice/PropertyUtil.h
@@ -22,7 +22,7 @@ namespace IceInternal
     /// @param properties The properties to consider.
     /// @param propertyArray The property array to search against.
     /// @throws UnknownPropertyException if unknown properties are found.
-    ICE_API void validatePropertiesWithPrefix(
+    void validatePropertiesWithPrefix(
         std::string_view prefix,
         const Ice::PropertiesPtr& properties,
         const PropertyArray* propertyArray);
-Original file line number
+Diff line change
@@ Expand Up / @@ -62,7 +62,7 @@ namespace @@
                 {
                     os << "\n    " << prop;
                 }
-                throw UnknownPropertyException(__FILE__, __LINE__, os.str());
+                throw UnknownPropertyException{__FILE__, __LINE__, os.str()};
             }
         }
@@ Expand Down @@