Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_nxp_enet_qos: implement set_config #82089

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theadib
Copy link

@theadib theadib commented Nov 26, 2024

implements the set_config api for the eth_nxp_enet_qos_mac driver
as in FRDM_MCXN947

Copy link

Hello @theadib, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@decsny
Copy link
Member

decsny commented Nov 26, 2024

Hi, the PR looks good at a glance, I will review more when I get a chance. For now make sure you ran the scripts/ci/check_compliance script and passed (expect clang format check is optional, the driver might already not pass clang format)

@dleach02
Copy link
Member

@theadib thankyou for the contributions. Can you address the compliance issue:

Commit message body line exceeds max length (85>75): "implements the set_config api for the eth_nxp_enet_qos_mac driver as in FRDM_MCXN947"

implements  the set_config api for the eth_nxp_enet_qos_mac driver
as in FRDM_MCXN947

Signed-off-by: Adib Taraben <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Ethernet platform: NXP Drivers NXP Semiconductors, drivers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants