drivers: lora: sx12xx: select SPI and GPIO #82083
Open
+9
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of depending on SPI/GPIO. This allows to just enable CONFIG_LORA=y + DT node in the application layer. The same pattern is nowadays followed by most drivers. Signed-off-by: Gerard Marull-Paretas <[email protected]>
This is no longer needed, drivers selects SPI and GPIO as needed. Signed-off-by: Gerard Marull-Paretas <[email protected]>
zephyrbot
requested review from
de-nordic,
JordanYates,
kartben,
Mani-Sadhasivam,
mniestroj,
nashif and
nordicjm
fabiobaltieri
approved these changes
Nov 26, 2024
kartben
approved these changes
Nov 26, 2024
mniestroj
approved these changes
Nov 26, 2024
JordanYates
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of depending on SPI/GPIO. This allows to just enable
CONFIG_LORA=y + DT node in the application layer. The same
pattern is nowadays followed by most drivers.
Also cleanup samples/tests.