-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: devicetree: clarify child node disabling #82064
base: main
Are you sure you want to change the base?
doc: devicetree: clarify child node disabling #82064
Conversation
Add a note to status property that disabled parent nodes do not implicitly disable child nodes. Issue zephyrproject-rtos#82040 Signed-off-by: Andreas Rudolf <[email protected]>
@@ -288,6 +288,9 @@ status | |||
devices must be enabled for the corresponding ``struct device`` in the | |||
Zephyr driver model to be allocated and initialized. | |||
|
|||
Note that a child node is not implicitly disabled when its parent node is | |||
disabled, i.e. child nodes should be disabled explicitly if desired. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could use the full name instead of the Latin. Not everyone is familiar with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The abbreviation i.e.
has already been used two times in the same document, so I assumed it would be OK, but I will gladly change all occurences if you like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can, I think it's good. If I were from a country that doesn't use Latin, I would be puzzled when I saw it and said, what the hell is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i.e. is used all over the place in zephyr, the documentation is in english, it's fine to stay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i.e. is used all over the place in zephyr, the documentation is in english, it's fine to stay
Then I'll rather leave it as it is, I hope that's OK with everyone. (I tried to find different variations by replacing it with "in other words" or similar but it seemed a bit unfitting to me to be honest)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I'll rather leave it as it is, I hope that's OK with everyone
Don't worry about it. This is just a suggestion that you can't follow, insignificant :)
(zephyr designated language is English)
Add a note to status property that disabled parent nodes do not implicitly disable child nodes.
Issue #82040