tests: benchmarks: optimize filters and use platform_key. #82032
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarks are not tests, we run them to verify they still work and do not bitrot. Running them on each architecture should be sufficient. This reduces amount of churn in CI and still allows them to be run individually on platforms. Signed-off-by: Anas Nashif <[email protected]>
nashif
added
the
Trivial
teburd
approved these changes
Nov 26, 2024
|
Likely we should add a few additional platform fields to help better key in on what we want
There's a few variations of qemu that cover these different cases but all share an arch (e.g. rv32). These things can lead to quite some variance of what we are bench marking I imagine. |
peter-mitsis
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks are not tests, we run them to verify they still work and do
not bitrot. Running them on each architecture should be sufficient.
This reduces amount of churn in CI and still allows them to be run
individually on platforms.
Signed-off-by: Anas Nashif [email protected]