drivers serial nrfx: Apply workaround also for bsim targets #81699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: UART
zephyrbot
requested review from
dcpleung,
jaz1-nordic,
kl-cruz,
magp-nordic and
masz-nordic
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_nordic
DNM
anangl
previously approved these changes
Nov 21, 2024
nordic-krch
previously approved these changes
Nov 21, 2024
Or more precisely, do not remove the workaround for them. The current HW models are accurate enough in this area for the workaround to work properly. Signed-off-by: Alberto Escolar Piedras <[email protected]>
Including not removing a workaround in the UART driver for bsim targets Signed-off-by: Alberto Escolar Piedras <[email protected]>
aescolar
force-pushed
the
no_uart_workarounds
branch
from
cbdf7a4
to
ce226ee
Compare
|
@anangl @nordic-krch thanks for the reviews, the last push is just a rebase + update of the west hal_nordic pointer from the PR to main. |
anangl
approved these changes
Nov 29, 2024
nordic-krch
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or more precisely, do not remove the workaround for them.
The current HW models are accurate enough in this area for the workaround to work properly.