Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: _extensions: scripts: apply ruff lint rules #81092

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

kartben
Copy link
Collaborator

@kartben kartben commented Nov 7, 2024

This makes all Python scripts in doc/ compliant with current ruff rules.

redirects.py is kept in the ignore list with regards to line length as keeping the ability to do block selection in this file can be particularly useful.

@pdgendt
Copy link
Collaborator

pdgendt commented Nov 21, 2024

#81070 has been merged 😉

@kartben
Copy link
Collaborator Author

kartben commented Nov 21, 2024

#81070 has been merged 😉

will come back to this shortly then :) Thank you!

doc/_extensions/zephyr/domain/__init__.py Outdated Show resolved Hide resolved
doc/_extensions/zephyr/kconfig/__init__.py Outdated Show resolved Hide resolved
@kartben kartben force-pushed the doc_fix_ruff branch 2 times, most recently from 50d2398 to fbc542a Compare November 22, 2024 15:50
This makes all Python scripts in doc/_extensions compliant w.r.t current
Ruff rules

Signed-off-by: Benjamin Cabé <[email protected]>
This makes all remaining Python scripts in doc compliant w.r.t current
Ruff rules

Signed-off-by: Benjamin Cabé <[email protected]>
@pdgendt
Copy link
Collaborator

pdgendt commented Nov 26, 2024

redirects.py is kept in the ignore list with regards to line length as keeping the ability to do block selection in this file can be particularly useful.

I would add the ignore to the file instead of keeping it in the excludes file. Ideally the excludes file is removed at some point.

# Ignore line-too-long to allow for block selection
# ruff: noqa: E501

See https://docs.astral.sh/ruff/tutorial/#ignoring-errors

@nashif nashif merged commit e544465 into zephyrproject-rtos:main Nov 26, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants