Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver: sensor: adxl367: Fix for conversion and SPI #80617

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

vladislav-pejic
Copy link
Contributor

This is a fix for:

  • Extra 0 in conversion of acceleration values in adxl367_accel_convert.
  • Conversion of temperature values in adxl367_temp_convert.
  • SPI communication when RTIO is used in SPI driver. When in adxl367_bus_access, const struct spi_buf buf[3] is used, spi_rtio_copy function won't set correct buffers and length for buf[2] and that will cause exception when that buffer is processed.

Signed-off-by: Vladislav Pejic [email protected]

Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are three separate bug fixes, can you please split them into three separate commits (they can all stay in this PR)? This will help if we later find that one of the fixes was incorrect and can revert just that part.

@vladislav-pejic
Copy link
Contributor Author

Since these are three separate bug fixes, can you please split them into three separate commits (they can all stay in this PR)? This will help if we later find that one of the fixes was incorrect and can revert just that part.

Done. Is it ok like this?

Fix for SPI communication when RTIO is used in SPI driver. When in
adxl367_bus_access, const struct spi_buf buf[3] is used,
spi_rtio_copy function won't set correct buffers and length
for buf[2] and that will cause exception when that buffer is
processed.

Signed-off-by: Vladislav Pejic <[email protected]>
Fix for conversion of temperature values in adxl367_temp_convert
and missing break statement.

Signed-off-by: Vladislav Pejic <[email protected]>
Fix for extra 0 in conversion of acceleration values in
adxl367_accel_convert.

Signed-off-by: Vladislav Pejic <[email protected]>
@MaureenHelm MaureenHelm added this to the v4.1.0 milestone Nov 26, 2024
@nashif nashif merged commit 04c70d6 into zephyrproject-rtos:main Nov 26, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Sensors Sensors platform: ADI Analog Devices, Inc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants