Backport 79830 to v2.7 branch: Add stream_flash_erase_page range check #80615
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-nordic
requested review from
nashif,
nvlsianpu,
carlescufi,
galak and
MaureenHelm
as code owners
github-actions
bot
added
area: Tests
|
@nashif I should drop the test commit, right? |
de-nordic
force-pushed
the
backport-79830-to-v2.7-branch
branch
from
9735411
to
a5471aa
Compare
github-actions
bot
removed
the
area: Tests
Added check where stream_flash_erase_page checks if requested offset is actually within stream flash designated area. Fixes #79800 Signed-off-by: Dominik Ermel <[email protected]> (cherry picked from commit 8714c17)
de-nordic
force-pushed
the
backport-79830-to-v2.7-branch
branch
from
a5471aa
to
f67cbe0
Compare
github-actions
bot
added
the
area: Tests
de-nordic
force-pushed
the
backport-79830-to-v2.7-branch
branch
from
f67cbe0
to
f173c1e
Compare
github-actions
bot
removed
the
area: Tests
|
please put something useful in the PR title, PR numbers do not tell me anything. |
de-nordic
changed the title
|
@nashif I am sorry, but it seems that CI for this will always fail, due to missing runners or out of date configuration. I can not do anything about this. |
nashif
approved these changes
Nov 8, 2024
kartben
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where: stream_flash: stream_flash_erase_page does not check whether requested offset is in range of stream flash owned area (#79800)
Fixes #80460
Failed backport #80460