samples: drivers: video: add capture to lvgl sample #71463

CharlesDias · 2024-04-13T15:06:00Z

Add sample application to capture an image frame from a camera and send it for display on the LCD.

This PR depends on:

CharlesDias · 2024-04-13T15:17:34Z

Dear @kartben and @nashif.

This sample has been tested on the mini_stm32h743 target with the OV2640 camera model. It depends on the PR #71462.

Should I move this sample to board-specific samples folder?

~~west build -p -b mini_stm32h743 samples/subsys/video/capture_to_lvgl/ -- -DCONFIG_BOOT_DELAY=2000~~

This version works with "VIDEO_SW_GENERATOR"

west build -p -b mini_stm32h743 samples/drivers/video/capture_to_lvgl/ -- -DCONFIG_BOOT_DELAY=2000

and with shield #77949.

west build -p -b mini_stm32h743 samples/drivers/video/capture_to_lvgl/ --shield weact_ov2640_cam_module -- -DCONFIG_BOOT_DELAY=2000

Thanks!

document_4958923842157282345.mp4

CharlesDias · 2024-04-14T08:45:22Z

Fix compliance check errors.

The error "Found references to undefined Kconfig symbols" happened because this PR depend on the PR #71462

CharlesDias · 2024-04-17T22:00:06Z

Fix image alignment

document_4972170831263171749.mp4

CharlesDias · 2024-04-25T17:24:47Z

git rebase

CharlesDias · 2024-04-25T18:30:55Z

Add the clock rate control property. This property depend on #71962

CharlesDias · 2024-04-27T10:33:57Z

Remove shell device, increase main stack size, and change the video buffer array from 1 to 2.

samples/subsys/video/capture_to_lcd/boards/mini_stm32h743.conf

samples/subsys/video/capture_to_lcd/boards/mini_stm32h743.overlay

josuah · 2024-05-04T07:11:54Z

As I understand it, with the LVGL addition, this makes it closer to a demo (showing most of the capabilities of a system) than a sample code (minimal code to implement a single feature).

Is LVGL required for the video to display flow to work?
Maybe splitting/moving it to a separate sample inside samples/module/lvgl since it requires the LVGL module?

josuah · 2024-09-17T00:38:07Z

Well, actually the shield is merged now! :)
So while moving the config to the shield is a good thing to do, you can now do this in this PR.
Doing so will also trigger a new CI cycle.

CharlesDias · 2024-09-17T12:04:32Z

Well, actually the shield is merged now! :)

Unfortunately, no! The shield PR is still open. I just removed it from the PR dependency list above.

boards: shields: add suport for weact_ov2640_cam_module #77949

CharlesDias · 2024-09-17T12:10:24Z

git commit --amend to force CI to run.

CharlesDias · 2024-09-17T12:31:24Z

The CI passed now! Thanks for the tip, @josuah! :-)

josuah

There is one last reference to something that is just about to be merged :shield: weact_ministm32h7xx_ov2640.
The rest all looks like being ready.

Some config like CONFIG_VIDEO_HFLIP or DT_HAS_CHOSEN(zephyr_camera) are not used by this example, but were still tested against a custom shield (being submitted), so are known to work, and can be used by anyone integrating their own shield in the future.

This currently works with the test pattern generator.

samples/drivers/video/capture_to_lvgl/boards/mini_stm32h743.conf

samples/drivers/video/capture_to_lvgl/sample.yaml

samples/drivers/video/capture_to_lvgl/boards/mini_stm32h743.overlay

CharlesDias · 2024-09-24T19:43:21Z

Rebase.

CharlesDias · 2024-09-24T20:39:29Z

Update the samples.yaml by adding the integration_platforms; removed the pll and rcc configuration from mini_stm32h743.overlay; changed the default video width and height to the 320x240 resolution because display on native_sim/native/64 has the 320x240 size resolution.

josuah

This looks very minimal now. Easy to use as a starting point for graphics + video.

samples/drivers/video/capture_to_lvgl/README.rst

kartben · 2024-09-17T12:14:01Z

samples/drivers/video/capture_to_lvgl/README.rst

+   This sample application demonstrates how to use the video API to retrieve video
+   frames from a capture device and display them on an LCD via the LVGL library.


This should be much shorter and written as id completing the sentence "this sample shows how to..."

Suggested change

This sample application demonstrates how to use the video API to retrieve video

frames from a capture device and display them on an LCD via the LVGL library.

Capture video frames and display them on an LCD using LVGL.

Will be much more consistent with other samples, too: https://builds.zephyrproject.io/zephyr/pr/71463/docs/samples/drivers/video/video.html

Done. Thanks!

kartben · 2024-09-25T01:44:01Z

samples/drivers/video/capture_to_lvgl/README.rst

+a video capture device, writes a frame count message to the console, and then sends
+the frame to an LCD display.


Suggested change

a video capture device, writes a frame count message to the console, and then sends

the frame to an LCD display.

a video capture device, write a frame count message to the console, and then send

the frame to an LCD display.

Add sample application to capture an image frame from a camera and send it for display on LCD via the LVGL library. Signed-off-by: Charles Dias <[email protected]>

CharlesDias · 2024-09-25T11:05:35Z

Implemented @kartben suggestions.

zephyrbot added the area: Samples Samples label Apr 13, 2024

zephyrbot requested review from kartben and nashif April 13, 2024 15:06

zephyrbot assigned kartben Apr 13, 2024

CharlesDias marked this pull request as draft April 13, 2024 15:07

CharlesDias mentioned this pull request Apr 13, 2024

drivers: video: Add support for STM32 DCMI #71462

Merged

CharlesDias force-pushed the video_capture_to_lcd branch 3 times, most recently from 2ef83aa to 6d4059d Compare April 14, 2024 08:37

CharlesDias mentioned this pull request Apr 17, 2024

drivers: video: STM32 Digital camera interface (DCMI) driver #70674

Open

4 tasks

CharlesDias force-pushed the video_capture_to_lcd branch 3 times, most recently from 5c3a8bf to e3c5082 Compare April 17, 2024 21:54

CharlesDias force-pushed the video_capture_to_lcd branch from e3c5082 to b4accd6 Compare April 25, 2024 17:24

CharlesDias mentioned this pull request Apr 25, 2024

drivers: video: ov2640: add clock rate control property #71962

Merged

CharlesDias force-pushed the video_capture_to_lcd branch from b4accd6 to 459670f Compare April 25, 2024 18:30

CharlesDias force-pushed the video_capture_to_lcd branch from 459670f to 72cae10 Compare April 27, 2024 10:32

CharlesDias force-pushed the video_capture_to_lcd branch 2 times, most recently from 82464f5 to aebab04 Compare April 27, 2024 20:53

CharlesDias marked this pull request as ready for review April 27, 2024 20:56

CharlesDias force-pushed the video_capture_to_lcd branch from aebab04 to 9b21fef Compare April 28, 2024 19:13

erwango reviewed May 3, 2024

View reviewed changes

samples/subsys/video/capture_to_lcd/boards/mini_stm32h743.conf Outdated Show resolved Hide resolved

erwango requested changes May 3, 2024

View reviewed changes

samples/subsys/video/capture_to_lcd/boards/mini_stm32h743.overlay Outdated Show resolved Hide resolved

CharlesDias force-pushed the video_capture_to_lcd branch from b91521a to 24b6622 Compare September 17, 2024 12:09

CharlesDias requested review from kartben, erwango and josuah September 17, 2024 12:32

josuah previously approved these changes Sep 17, 2024

View reviewed changes

erwango requested changes Sep 24, 2024

View reviewed changes

CharlesDias force-pushed the video_capture_to_lcd branch from 24b6622 to b222f27 Compare September 24, 2024 19:43

CharlesDias dismissed josuah’s stale review via 0aa5882 September 24, 2024 20:25

CharlesDias force-pushed the video_capture_to_lcd branch from b222f27 to 0aa5882 Compare September 24, 2024 20:25

CharlesDias force-pushed the video_capture_to_lcd branch from 0aa5882 to 008914f Compare September 24, 2024 21:53

josuah previously approved these changes Sep 24, 2024

View reviewed changes

samples/drivers/video/capture_to_lvgl/README.rst Show resolved Hide resolved

kartben requested changes Sep 25, 2024

View reviewed changes

samples: drivers: video: add capture to lvgl sample

d823ee6

Add sample application to capture an image frame from a camera and send it for display on LCD via the LVGL library. Signed-off-by: Charles Dias <[email protected]>

CharlesDias dismissed josuah’s stale review via d823ee6 September 25, 2024 11:03

CharlesDias force-pushed the video_capture_to_lcd branch from 008914f to d823ee6 Compare September 25, 2024 11:03

josuah mentioned this pull request Sep 25, 2024

samples: drivers: video: capture: Add format config #77879

Merged

kartben approved these changes Sep 25, 2024

View reviewed changes

erwango approved these changes Sep 25, 2024

View reviewed changes

josuah requested review from erwango and josuah September 25, 2024 11:58

josuah approved these changes Sep 25, 2024

View reviewed changes

nashif merged commit 57a8a7c into zephyrproject-rtos:main Sep 26, 2024
17 checks passed

CharlesDias mentioned this pull request Oct 13, 2024

boards: shields: add suport for weact_ov5640_cam_module #79759

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

samples: drivers: video: add capture to lvgl sample #71463

samples: drivers: video: add capture to lvgl sample #71463

CharlesDias commented Apr 13, 2024 •

edited

Loading

CharlesDias commented Apr 13, 2024 •

edited

Loading

CharlesDias commented Apr 14, 2024

CharlesDias commented Apr 17, 2024

CharlesDias commented Apr 25, 2024

CharlesDias commented Apr 25, 2024

CharlesDias commented Apr 27, 2024

josuah commented May 4, 2024

josuah commented Sep 17, 2024

CharlesDias commented Sep 17, 2024

CharlesDias commented Sep 17, 2024 •

edited

Loading

CharlesDias commented Sep 17, 2024

josuah left a comment

CharlesDias commented Sep 24, 2024

CharlesDias commented Sep 24, 2024

josuah left a comment

kartben Sep 17, 2024 •

edited

Loading

CharlesDias Sep 25, 2024

kartben Sep 25, 2024

CharlesDias Sep 25, 2024

CharlesDias commented Sep 25, 2024

		This sample application demonstrates how to use the video API to retrieve video
		frames from a capture device and display them on an LCD via the LVGL library.

	This sample application demonstrates how to use the video API to retrieve video
	frames from a capture device and display them on an LCD via the LVGL library.
	Capture video frames and display them on an LCD using LVGL.

		a video capture device, writes a frame count message to the console, and then sends
		the frame to an LCD display.

samples: drivers: video: add capture to lvgl sample #71463

samples: drivers: video: add capture to lvgl sample #71463

Conversation

CharlesDias commented Apr 13, 2024 • edited Loading

CharlesDias commented Apr 13, 2024 • edited Loading

CharlesDias commented Apr 14, 2024

CharlesDias commented Apr 17, 2024

CharlesDias commented Apr 25, 2024

CharlesDias commented Apr 25, 2024

CharlesDias commented Apr 27, 2024

josuah commented May 4, 2024

josuah commented Sep 17, 2024

CharlesDias commented Sep 17, 2024

CharlesDias commented Sep 17, 2024 • edited Loading

CharlesDias commented Sep 17, 2024

josuah left a comment

Choose a reason for hiding this comment

CharlesDias commented Sep 24, 2024

CharlesDias commented Sep 24, 2024

josuah left a comment

Choose a reason for hiding this comment

kartben Sep 17, 2024 • edited Loading

Choose a reason for hiding this comment

CharlesDias Sep 25, 2024

Choose a reason for hiding this comment

kartben Sep 25, 2024

Choose a reason for hiding this comment

CharlesDias Sep 25, 2024

Choose a reason for hiding this comment

CharlesDias commented Sep 25, 2024

CharlesDias commented Apr 13, 2024 •

edited

Loading

CharlesDias commented Apr 13, 2024 •

edited

Loading

CharlesDias commented Sep 17, 2024 •

edited

Loading

kartben Sep 17, 2024 •

edited

Loading