-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hwmv2: port STM32L5 SoCs and boards #68706
Conversation
f6a5e03
to
0a23f72
Compare
Migrate STM2L5 series to new HW model. Signed-off-by: Erwan Gouriou <[email protected]>
config BOARD_NUCLEO_L552ZE_Q_STM32L552XX_NS | ||
bool | ||
select SOC_STM32L552XX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not resolved please amend commits in future rather than adding to the final commit with an incorrect commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an incorrect commit
. Did you read commit description ?
This is actually a dedicated refactoring commit with a proper justification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
soc: stm32l5: Rename overlays for nucleo_l552ze_q ns target.
File name should now be nucleo_l552ze_q_stm32l552xx_ns.overlay
No relation to this change at all
name: nucleo_l552ze_q | ||
vendor: st | ||
socs: | ||
- name: stm32l552xx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name should go left by 2 spaced, then all lines below also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the way it is generated by scripts/utils/board_v1_to_v2.py
script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
our .yamllint
file says indentation: spaces: 2
, I guess it would complain if this was wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have .yaml files with both additional indents and without, I remember seeing a warning on a PR but can't remember which one it was but they can't both be right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from https://github.com/zephyrproject-rtos/zephyr/blob/main/.yamllint
indentation:
spaces: 2
indent-sequences: consistent
the lists are a bit odd for some reasons, the linter just checks that the style is coherent throughout the file
Port the board to HWMv2. Signed-off-by: Erwan Gouriou <[email protected]>
Port the board to HWMv2. Signed-off-by: Erwan Gouriou <[email protected]>
Need to update board name scheme for L5 ns targets. Signed-off-by: Erwan Gouriou <[email protected]>
Rather than configuring USE_DT_CODE_PARTITION in all ns targets, do it conditionally as part of SoC description. This allows cleaning up some BOARD dedicated symbols that are now useless. Signed-off-by: Erwan Gouriou <[email protected]>
File name should now be nucleo_l552ze_q_stm32l552xx_ns.overlay Signed-off-by: Erwan Gouriou <[email protected]>
CI is failing for |
It is actually failing on main branch as well. We'll fix it there. |
3932ac8
into
zephyrproject-rtos:collab-hwm
No description provided.