Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hwmv2: port STM32L5 SoCs and boards #68706

Merged
merged 6 commits into from
Feb 13, 2024

Conversation

erwango
Copy link
Member

@erwango erwango commented Feb 7, 2024

No description provided.

boards/st/nucleo_l552ze_q/Kconfig.defconfig Outdated Show resolved Hide resolved
boards/st/nucleo_l552ze_q/Kconfig.nucleo_l552ze_q Outdated Show resolved Hide resolved
boards/st/nucleo_l552ze_q/doc/nucleol552ze_q.rst Outdated Show resolved Hide resolved
boards/st/stm32l562e_dk/Kconfig.stm32l562e_dk Outdated Show resolved Hide resolved
Migrate STM2L5 series to new HW model.

Signed-off-by: Erwan Gouriou <[email protected]>
Comment on lines 7 to 9
config BOARD_NUCLEO_L552ZE_Q_STM32L552XX_NS
bool
select SOC_STM32L552XX
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not resolved please amend commits in future rather than adding to the final commit with an incorrect commit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an incorrect commit. Did you read commit description ?
This is actually a dedicated refactoring commit with a proper justification.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

soc: stm32l5: Rename overlays for nucleo_l552ze_q ns target.

File name should now be nucleo_l552ze_q_stm32l552xx_ns.overlay

No relation to this change at all

boards/st/stm32l562e_dk/Kconfig.stm32l562e_dk Outdated Show resolved Hide resolved
name: nucleo_l552ze_q
vendor: st
socs:
- name: stm32l552xx
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • name should go left by 2 spaced, then all lines below also

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the way it is generated by scripts/utils/board_v1_to_v2.py script.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our .yamllint file says indentation: spaces: 2, I guess it would complain if this was wrong.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have .yaml files with both additional indents and without, I remember seeing a warning on a PR but can't remember which one it was but they can't both be right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@fabiobaltieri fabiobaltieri Feb 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from https://github.com/zephyrproject-rtos/zephyr/blob/main/.yamllint

  indentation:
    spaces: 2
    indent-sequences: consistent

the lists are a bit odd for some reasons, the linter just checks that the style is coherent throughout the file

Port the board to HWMv2.

Signed-off-by: Erwan Gouriou <[email protected]>
Port the board to HWMv2.

Signed-off-by: Erwan Gouriou <[email protected]>
Need to update board name scheme for L5 ns targets.

Signed-off-by: Erwan Gouriou <[email protected]>
Rather than configuring USE_DT_CODE_PARTITION in all ns targets,
do it conditionally as part of SoC description.

This allows cleaning up some BOARD dedicated symbols that are now
useless.

Signed-off-by: Erwan Gouriou <[email protected]>
File name should now be nucleo_l552ze_q_stm32l552xx_ns.overlay

Signed-off-by: Erwan Gouriou <[email protected]>
@nordicjm
Copy link
Collaborator

CI is failing for nucleo_f722ze and another stm32 board, not part of this conversion but were converted previously

@erwango
Copy link
Member Author

erwango commented Feb 13, 2024

CI is failing for nucleo_f722ze and another stm32 board, not part of this conversion but were converted previously

It is actually failing on main branch as well. We'll fix it there.

@nordicjm nordicjm merged commit 3932ac8 into zephyrproject-rtos:collab-hwm Feb 13, 2024
18 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants