Skip to content

Commit

Permalink
west: sign.py: always log the rimage command
Browse files Browse the repository at this point in the history
rimage is very verbose by default and has no -q(uiet) option, so saving
one line out of more than 100 lines is pointless.

RimageSigner.sign() was already very complex and suffering from
combinatorial explosion of parameters. With .toml
pre-processing (#65411) it's getting worse, so we really need all build
logs to show the complete rimage command.

Signed-off-by: Marc Herbert <[email protected]>
  • Loading branch information
marc-hb authored and carlescufi committed Dec 15, 2023
1 parent c13cf99 commit a65b8d4
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions scripts/west_commands/sign.py
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,8 @@ def sign(self, command, build_dir, build_conf, formats):

sign_base = [tool_path]

# Sub-command arg '-q' takes precedence over west '-v'
# Align rimage verbosity.
# Sub-command arg 'west sign -q' takes precedence over west '-v'
if not args.quiet and args.verbose:
sign_base += ['-v'] * args.verbose

Expand All @@ -562,8 +563,7 @@ def sign(self, command, build_dir, build_conf, formats):
sign_base += (['-o', out_bin] + sign_config_extra_args +
extra_ri_args + args.tool_args + components)

if not args.quiet:
log.inf(quote_sh_list(sign_base))
command.inf(quote_sh_list(sign_base))
subprocess.check_call(sign_base)

if no_manifest:
Expand Down

0 comments on commit a65b8d4

Please sign in to comment.