Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commands: Show less generic error when no manifest is loaded #671

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

commands: Show less generic error when no manifest is loaded #671

wants to merge 1 commit into from

Commits on Jun 2, 2023

  1. commands: Show less generic error when no manifest is loaded 

    If loading the manifest fails, running a command which needs to read the
manifest could result in this being shown:

   FATAL ERROR: can't run west manifest; it requires the manifest, which
   was not available. Try "west manifest --validate" to debug.

In this case, trying "west manifest --validate" would also display the
same error, which is not very helpful.

Instead of that, west can print the deferred error from load_manifest(),
which contains a more specific message. Rework the WestCommand.manifest
property handling by adding a dummy _ManifestRequired exception. It is
caught by run_builtin() in main.py, which can access the stored error.

Signed-off-by: Grzegorz Swiderski <[email protected]>
    @57300
    57300 committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    7a04b75 View commit details
    Browse the repository at this point in the history