Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: Fix using deprecated/removed wget option #836

Closed
wants to merge 1 commit into from

Conversation

jhedberg
Copy link
Member

Recent wget versions don't have the --show-progress option anymore and will generate a "wget: unrecognized option '--show-progress'" error (this happens e.g. with latest Fedora). The correct option to use seems to be --progress=bar, which should do the same thing.

Recent wget versions don't have the --show-progress option anymore and will
generate a "wget: unrecognized option '--show-progress'" error (this
happens e.g. with latest Fedora). The correct option to use seems to be
--progress=bar, which should do the same thing.

Signed-off-by: Johan Hedberg <[email protected]>
@jhedberg
Copy link
Member Author

Note: I wasn't able to verify this on Windows, but I'd assume the same option should work there as well.

Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wget2 is not wget, and Fedora made a mistake of trying to replace wget with wget2.

See #771 (comment).

Fedora should fix this, not us.

p.s. See also #771 (comment). RHEL 10 reverted this mistake as well.

wget -q --show-progress -N -O "${toolchain_filename}" "${toolchain_uri}"
wget -q --progress=bar -N -O "${toolchain_filename}" "${toolchain_uri}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This results in progress bar not showing up at all in the "real wget."

@jhedberg
Copy link
Member Author

Thanks @stephanosio, I wasn't aware of this wget vs wget2 distinction. I completely agree Fedora is at fault, however the current end result is that new Zephyr users who follow our getting started guide end up having a negative experience - I wonder if there's something we could still do, e.g. mention this somewhere in the documentation, or even try to work around it in the setup script?

@jhedberg jhedberg closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants